baggage propagation #12389
baggage propagation #12389
Conversation
|
The issue was that it didn't propagate to metrics... but you don't test metrics. I'd expect changes to This can be considered a good step, as it is now propagated to the application. Basically, when you say "propagation" you need to say what you are propagating to. But this would only be one part of what had been discussed earlier. (And this can go in before the rest of the metrics is working.) |
ejona86
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
AgraVator
force-pushed
the
baggage-prop
branch
from
d4e86d7 to
8f61af3
Compare
| Context serverCallContext = Context.current(); | ||
| serverCallContext = serverCallContext.with(span); | ||
| Baggage baggage = BAGGAGE_KEY.get(io.grpc.Context.current()); | ||
| if (baggage != null) { |
There was a problem hiding this comment.
If it was never set...
There was a problem hiding this comment.
not present in the header...
There was a problem hiding this comment.
There was a problem hiding this comment.
hmm, so we are getting it from the grpc context which uses
/**
* Get the value from the specified context for this key.
*/
@SuppressWarnings("unchecked")
public T get(Context context) {
T value = (T) PersistentHashArrayMappedTrie.get(context.keyValueEntries, this);
return value == null ? defaultValue : value;
}
and can return null
There was a problem hiding this comment.
But it is added unconditionally to the context earlier, so it shouldn't be missing. If it is missing, that seems like a bug, and something we'd want to know about. Seems we should do something, other than ignore it.
opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryMetricsModule.java
Outdated
Show resolved
Hide resolved
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
When merging, fix the commit title to start with "opentelemetry:" and include any relevant details in the description. For example, there is an internal bug for this, so that should be included in the commit message.
AgraVator
force-pushed
the
baggage-prop
branch
from
9499261 to
154e7c1
Compare
…lps with b/406058193 (grpc#12389)
3 participants
No description provided.